Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: put types condition first in the syncing script #26743

Merged
merged 2 commits into from
May 15, 2023

Conversation

Andarist
Copy link
Contributor

Follow up to #26630 , fixes what @MikeMcC399 reported in the comment here: #26630 (comment)

@MikeMcC399
Copy link
Contributor

@Andarist

I am still getting a diff, however this appears to be due to a typo.

Have you actually tested this yourself?

diff --git a/cli/package.json b/cli/package.json
index e0d0a3303f..f9c2d09f14 100644
--- a/cli/package.json
+++ b/cli/package.json
@@ -160,7 +160,7 @@
     "./svelte": {
       "types": "./svelte/dist/index.d.ts",
       "import": "./svelte/dist/cypress-svelte.esm-bundler.js",
-      "require": "./svelte/dist/cypress-selte.cjs.js"
+      "require": "./svelte/dist/cypress-svelte.cjs.js"
     }
   },
   "workspaces": {

@cypress
Copy link

cypress bot commented May 12, 2023

26 flaky tests on run #46245 ↗︎

0 27290 1308 0 Flakiness 26

Details:

fix(internal): put types condition first in the syncing script
Project: cypress Commit: 3b8c2a1011
Status: Passed Duration: 22:22 💡
Started: May 12, 2023 1:19 PM Ended: May 12, 2023 1:41 PM
Flakiness  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
delayed navigation > errors > redirects to an unexpected cross-origin and calls another command in the cy.origin command Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video

The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented May 12, 2023

@Andarist
Copy link
Contributor Author

Andarist commented May 12, 2023

@MikeMcC399 pushed out a fix for this typo, good catch

Have you actually tested this yourself?

Yeah, perhaps not to the full extent. When I located what was reordering those keys I kept running the build script in only one of the directories so I missed the typo in another one.

@Andarist Andarist changed the title fix(internal): put types condition first in the syncing script chore: put types condition first in the syncing script May 12, 2023
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After executing

yarn
git status

I am no longer seeing any git diff generated.

@chrisbreiding
Copy link
Contributor

Thanks for the fix, @Andarist!

@chrisbreiding chrisbreiding merged commit 5f5df60 into cypress-io:develop May 15, 2023
@Andarist Andarist deleted the fix/syncing-script branch May 15, 2023 16:01
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants