-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: put types condition first in the syncing script #26743
chore: put types condition first in the syncing script #26743
Conversation
I am still getting a diff, however this appears to be due to a typo. Have you actually tested this yourself?
|
26 flaky tests on run #46245 ↗︎
Details:
e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
create-from-component.cy.ts • 1 flaky test • app-e2e
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|
@MikeMcC399 pushed out a fix for this typo, good catch
Yeah, perhaps not to the full extent. When I located what was reordering those keys I kept running the build script in only one of the directories so I missed the typo in another one. |
24a9113
to
a108ccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After executing
yarn
git status
I am no longer seeing any git diff
generated.
Thanks for the fix, @Andarist! |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Follow up to #26630 , fixes what @MikeMcC399 reported in the comment here: #26630 (comment)