Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add browser state action for debug (#26763) #26884

Merged
merged 5 commits into from
Jun 2, 2023

Conversation

dkasper-was-taken
Copy link
Contributor

@dkasper-was-taken dkasper-was-taken commented May 30, 2023

Additional details

Steps to test

  • Open a project with associated Cloud Runs, note run not currently active
  • Navigate to a non-debug route (Specs, Runs, Settings, etc)
  • Open GraphiQL, add entries below
mutation SpecsListHeader_ShowDebugForCloudRun($runNumber: Int!) {
  showDebugForCloudRun(runNumber: $runNumber) { machineId }
}
...
{
  "runNumber": <your above noted cloud run number>
}

How has the user experience changed?

No UX changes associated with the action only

PR Tasks

@dkasper-was-taken dkasper-was-taken self-assigned this May 30, 2023
@cypress
Copy link

cypress bot commented May 30, 2023

31 flaky tests on run #46982 ↗︎

0 27304 1308 0 Flakiness 31

Details:

Revert route change, update spec description
Project: cypress Commit: 8c6d0e8900
Status: Passed Duration: 20:54 💡
Started: Jun 2, 2023 6:58 PM Ended: Jun 2, 2023 7:19 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found Output Screenshots Video

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

packages/server/lib/open_project.ts Show resolved Hide resolved
packages/server/lib/makeDataContext.ts Outdated Show resolved Hide resolved
packages/data-context/src/actions/ProjectActions.ts Outdated Show resolved Hide resolved
packages/data-context/src/actions/ProjectActions.ts Outdated Show resolved Hide resolved
- remove unneeded async and test context
- genericize openProject function
@dkasper-was-taken dkasper-was-taken requested a review from a team June 1, 2023 21:51
Copy link
Contributor

@warrensplayer warrensplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction Mike was going with his comment about a more generic approach, but I wonder if this is a little bit of an AHA scenario. I am fine with your original specific solution, but can go along with the majority if we want to keep the current implementation.

Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and it looks good to me. Just one minor comment

@astone123
Copy link
Contributor

@warrensplayer agreed, I think this fills the use case that we need right now - if we find that later we need to do this again, at that point we should make it more generic. At this time I don't see a reason to do that

@dkasper-was-taken dkasper-was-taken dismissed mike-plummer’s stale review June 2, 2023 19:01

Out of Office for re-review and discussed in other reviewer comments.

@dkasper-was-taken dkasper-was-taken merged commit 9c4d5f7 into develop Jun 2, 2023
@dkasper-was-taken dkasper-was-taken deleted the ct-26763-debug-cloudrun-action branch June 2, 2023 19:40
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2023

Released in 12.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.14.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logic to change browser state
4 participants