-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add browser state action for debug (#26763) #26884
Conversation
31 flaky tests on run #46982 ↗︎
Details:
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
create-from-component.cy.ts • 2 flaky tests • app-e2e
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e
The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
- remove unneeded async and test context - genericize openProject function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction Mike was going with his comment about a more generic approach, but I wonder if this is a little bit of an AHA scenario. I am fine with your original specific solution, but can go along with the majority if we want to keep the current implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out and it looks good to me. Just one minor comment
@warrensplayer agreed, I think this fills the use case that we need right now - if we find that later we need to do this again, at that point we should make it more generic. At this time I don't see a reason to do that |
Out of Office for re-review and discussed in other reviewer comments.
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Steps to test
How has the user experience changed?
No UX changes associated with the action only
PR Tasks
cypress-documentation
?type definitions
?