-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: video compression false #27009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
breaking/video_compression_false
branch
from
June 13, 2023 02:16
ef909c3
to
d3ecbba
Compare
system-tests/projects/react-vite-ts-configured/cypress.config.ts
Outdated
Show resolved
Hide resolved
system-tests/projects/vue3-vite-ts-custom-index-html/cypress.config.ts
Outdated
Show resolved
Hide resolved
system-tests/projects/vue3-vite-ts-configured/cypress.config.ts
Outdated
Show resolved
Hide resolved
emilyrohrbough
approved these changes
Jun 13, 2023
weird thought I committed these 😅 |
chrisbreiding
approved these changes
Jun 15, 2023
AtofStryker
force-pushed
the
feat/set_video_false
branch
2 times, most recently
from
June 16, 2023 19:03
129a152
to
a66b1fe
Compare
Update system-tests/projects/ts-proj-5/cypress.config.ts Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update system-tests/projects/vite-simple/cypress.config.js Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update system-tests/projects/react-vite-ts-configured/cypress.config.ts Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update system-tests/projects/svelte-vite/cypress.config.js Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update system-tests/projects/ts-proj-4-5/cypress.config.ts Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update system-tests/projects/webpack-dev-server-ts/cypress.config.ts Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update system-tests/projects/vue3-vite-ts-configured/cypress.config.ts Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update system-tests/projects/vue3-vite-ts-custom-index-html/cypress.config.ts Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update cli/CHANGELOG.md Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Update cli/CHANGELOG.md Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
AtofStryker
force-pushed
the
breaking/video_compression_false
branch
from
June 20, 2023 18:07
50609b0
to
1d57c26
Compare
14 flaky tests on run #47919 ↗︎
Details:
e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkitThe first 5 flaky specs are shown, see all 6 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
For Cypress v13 , video will be set to false by default. In addition, we will also be setting
videoCompression
to false. This PR implements those changes.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
? breaking: update documentation by setting videoCompression: false cypress-documentation#5301type definitions
?