breaking: Remove deprecated nodeVersion configuration option #27059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcC399
reviewed
Jun 16, 2023
MikeMcC399
reviewed
Jun 16, 2023
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
mjhenkes
commented
Jun 16, 2023
| @@ -250,7 +250,7 @@ const convertRelativeToAbsolutePaths = (projectRoot: string, obj: Config) => { | |||
| // instead of the built-in Node process, specify a path to 3rd party Node | |||
| export const setNodeBinary = (obj: Config, userNodePath?: string, userNodeVersion?: string) => { | |||
| // if execPath isn't found we weren't executed from the CLI and should used the bundled node version. | |||
| if (userNodePath && userNodeVersion && obj.nodeVersion !== 'bundled') { | |||
| if (userNodePath && userNodeVersion) { | |||
There was a problem hiding this comment.
We could still end up using 'bundled' if user node isn't found.
mjhenkes
commented
Jun 16, 2023
| @@ -1022,14 +1022,6 @@ export const AllCypressErrors = { | |||
|
|
|||
| Please verify that this is the path to a valid, unpacked WebExtension.` | |||
| }, | |||
| COULD_NOT_FIND_SYSTEM_NODE: (nodeVersion: string) => { | |||
There was a problem hiding this comment.
This error was dead code
26 flaky tests on run #47812 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > establishes foobar spec bridge |
Output
Video
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| scaffolding component testing > 3rd party ct plugin > Scaffolds component testing for Solid using Vite |
Output
Screenshots
Video
|
|
The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
chrisbreiding
approved these changes
Jun 16, 2023
mjhenkes
changed the title
AtofStryker
approved these changes
Jun 16, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeVersionis set tobundled#27016Additional details
Removes the 'nodeVersion' configuration option.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?