chore: add v13 welcome page content #27549

AtofStryker · 2023-08-14T16:06:14Z

Closes N/A

Additional details

Adds the v13 welcome/splash page with updated content

Steps to test

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

chore: add video link for v13 inside graphql context and root resolver. add migration tests outside of migration manager and update component tests to test aspects chore: update copy to most recent. Needs onlink deployments chore: opt for named slot in major version welcome as we still want to show the changes whether or not the video is present chore: fix video margin by shrinking the margin for a more appealing loadout chore: update onlinks for what is expected in deploy chore: adjust margins around video, move video up, and reduce margin on major welcome title chore: bump release date to 8/29 chore: update stubbed query to reference actual video

jennifer-shehane

Content looks good, I didn't do a thorough code review and would like someone to do that and get it up and running in their review.

AtofStryker · 2023-08-18T20:39:06Z

Content looks good, I didn't do a thorough code review and would like someone to do that and get it up and running in their review.

Sounds good. The v13 video is in staging currently, so whoever tests this would need to run:

CYPRESS_INTERNAL_ENV=staging yarn cypress:open

inside the packages/launchpad

marktnoonan · 2023-08-21T15:51:20Z

I'll plan to pull this down later today and review!

AtofStryker · 2023-08-21T16:45:06Z

@tgriesser I want to double check and make sure I handled the resolution properly in the graphQL resolver.

ryanthemanuel · 2023-08-23T19:30:09Z

packages/launchpad/src/Main.vue

-    />
+    >
+      <template
+        v-if="videoHtml"


Will this pass if videoHtml is ''?

It does not. v-if only evaluates with the expression is truthy https://vuejs.org/guide/essentials/conditional.html#v-if

ryanthemanuel · 2023-08-23T19:32:22Z

system-tests/projects/migration-v12-to-v13/cypress.config.js

@@ -0,0 +1,10 @@
+const { defineConfig } = require('cypress')


Where do these get run?

in the e2e migration test

cypress/packages/launchpad/cypress/e2e/migration.cy.ts

Line 1736 in fca2b37

describe('v13 migration welcome page with video', () => {

packages/launchpad/src/migration/MajorVersionWelcome.vue

marktnoonan · 2023-08-23T20:00:42Z

packages/launchpad/src/migration/MajorVersionWelcome.vue

            <div class="mb-[16px]">
              <ExternalLink
-                href="https://on.cypress.io/changelog#12-0-0"
+                href="https://on.cypress.io/changelog?utm_source=splash-page&utm_campaign=v13#13-0-0"


Generally we use only 2 values for utm_source - Binary: App or Binary: Launchpad. Is this intentionally different from that? I realize it's not documented well. There's a sheet that wrangles these values, it would be good to add these there. Medium seems more suitable than "source" for "splash page" based on the existing pattern.

But also curious - is there a particular person expecting to do some analysis later based on these params, or are we more playing it safe?

I'm probably not the best person to ask about the utm_source, but it was in the approved copy for the splash page. I wonder if it makes sense to update the utm_source to Binary: App and leverage medium for the splash page . Heres the copy for reference. I can ask the GTM team in slack

Good idea to clarify in Slack. Being consistent is nice but there's not a hard and fast rule.

packages/launchpad/src/migration/MajorVersionWelcome.vue

Co-authored-by: Mark Noonan <mark@cypress.io>

…_page_v13

marktnoonan

This all looks good to me, approving with the assumption that we figure out the UTM params before merge.

cypress · 2023-08-23T21:13:27Z

29 flaky tests on run #50422 ↗︎

0	28013	1354	0	29

Details:

stub migration src in network performance launchpad test on video as abortcontr...
Project: cypress	Commit: `2317e62e0e`
Status: Passed	Duration: 18:21 💡
Started: Aug 24, 2023 11:03 PM	Ended: Aug 24, 2023 11:21 PM

e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test		Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary		`Output`

e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test		Artifacts
cy.origin assertions > #consoleProps > .should() and .and()		`Output`

cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test		Artifacts
... > correctly returns currentRetry		`Output`
... > correctly returns currentRetry		`Output`
... > correctly returns currentRetry		`Output`

scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test		Artifacts
scaffolding component testing > vuecli5vue3 > scaffolds component testing for Vue CLI 5 w/ Vue 3 project		`Test Replay` `Output` `Screenshots`

config-files-error-handling.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test		Artifacts
Config files error handling > handles deprecated config fields		`Test Replay` `Output` `Screenshots`

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

…abortcontroller is difficult to test with current ctx setup

cypress-bot · 2023-08-29T17:25:16Z

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

AtofStryker force-pushed the chore/update_major_version_welcome_page_v13 branch from 5727579 to a59b58f Compare August 14, 2023 16:09

AtofStryker changed the title ~~feat: add v13 splash page content (wip)~~ chore: add v13 welcome page content Aug 14, 2023

AtofStryker self-assigned this Aug 14, 2023

AtofStryker force-pushed the chore/update_major_version_welcome_page_v13 branch from 15f97f7 to 4fd745f Compare August 18, 2023 19:01

AtofStryker force-pushed the chore/update_major_version_welcome_page_v13 branch from 56a4ca7 to fca2b37 Compare August 18, 2023 19:22

AtofStryker marked this pull request as ready for review August 18, 2023 19:23

AtofStryker requested review from marktnoonan, brian-mann and jennifer-shehane August 18, 2023 19:23

jennifer-shehane approved these changes Aug 18, 2023

View reviewed changes

AtofStryker requested a review from tgriesser August 21, 2023 16:44

ryanthemanuel reviewed Aug 23, 2023

View reviewed changes

marktnoonan reviewed Aug 23, 2023

View reviewed changes

packages/launchpad/src/migration/MajorVersionWelcome.vue Outdated Show resolved Hide resolved

marktnoonan reviewed Aug 23, 2023

View reviewed changes

packages/launchpad/src/migration/MajorVersionWelcome.vue Outdated Show resolved Hide resolved

marktnoonan reviewed Aug 23, 2023

View reviewed changes

packages/launchpad/src/migration/MajorVersionWelcome.vue Outdated Show resolved Hide resolved

AtofStryker and others added 4 commits August 23, 2023 16:15

Update packages/launchpad/src/migration/MajorVersionWelcome.vue

c8f5975

Co-authored-by: Mark Noonan <mark@cypress.io>

Update packages/launchpad/src/migration/MajorVersionWelcome.vue

ac750f1

Co-authored-by: Mark Noonan <mark@cypress.io>

chore: update code elements to be inlinecodefragments

5e3fdf5

Merge branch 'release/13.0.0' into chore/update_major_version_welcome…

7bbcd1c

…_page_v13

AtofStryker requested a review from ryanthemanuel August 23, 2023 20:35

marktnoonan approved these changes Aug 23, 2023

View reviewed changes

ryanthemanuel approved these changes Aug 23, 2023

View reviewed changes

chore: update utm links to reflect correct nomenclature

a780230

stub migration src in network performance launchpad test on video as …

2317e62

…abortcontroller is difficult to test with current ctx setup

AtofStryker force-pushed the chore/update_major_version_welcome_page_v13 branch from d31067f to 2317e62 Compare August 24, 2023 22:52

AtofStryker merged commit 150b04c into release/13.0.0 Aug 24, 2023

AtofStryker deleted the chore/update_major_version_welcome_page_v13 branch August 24, 2023 23:36

cypress bot mentioned this pull request Aug 25, 2023

breaking: v13.0.0 #27040

Merged

3 tasks

cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add v13 welcome page content #27549

chore: add v13 welcome page content #27549

AtofStryker commented Aug 14, 2023 •

edited

Loading

jennifer-shehane left a comment

AtofStryker commented Aug 18, 2023

marktnoonan commented Aug 21, 2023

AtofStryker commented Aug 21, 2023

ryanthemanuel Aug 23, 2023

AtofStryker Aug 23, 2023

ryanthemanuel Aug 23, 2023

AtofStryker Aug 23, 2023

marktnoonan Aug 23, 2023

AtofStryker Aug 23, 2023

marktnoonan Aug 23, 2023

marktnoonan left a comment

cypress bot commented Aug 23, 2023 •

edited

Loading

cypress-bot bot commented Aug 29, 2023

chore: add v13 welcome page content #27549

chore: add v13 welcome page content #27549

Conversation

AtofStryker commented Aug 14, 2023 • edited Loading

Additional details

Steps to test

How has the user experience changed?

PR Tasks

jennifer-shehane left a comment

Choose a reason for hiding this comment

AtofStryker commented Aug 18, 2023

marktnoonan commented Aug 21, 2023

AtofStryker commented Aug 21, 2023

ryanthemanuel Aug 23, 2023

Choose a reason for hiding this comment

AtofStryker Aug 23, 2023

Choose a reason for hiding this comment

ryanthemanuel Aug 23, 2023

Choose a reason for hiding this comment

AtofStryker Aug 23, 2023

Choose a reason for hiding this comment

marktnoonan Aug 23, 2023

Choose a reason for hiding this comment

AtofStryker Aug 23, 2023

Choose a reason for hiding this comment

marktnoonan Aug 23, 2023

Choose a reason for hiding this comment

marktnoonan left a comment

Choose a reason for hiding this comment

cypress bot commented Aug 23, 2023 • edited Loading

29 flaky tests on run #50422 ↗︎

cypress-bot bot commented Aug 29, 2023

AtofStryker commented Aug 14, 2023 •

edited

Loading

cypress bot commented Aug 23, 2023 •

edited

Loading