-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support experimentalSingleTabRunMode in protocol #27659
Conversation
Passing run #50498 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the above suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good besides the system-test failures. We should be g2g once those are fixed
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
experimentalSingleTabRunMode
is enabled, the same tab is used for multiple specs. As such, theprotocolManager.connectToBrowser
method is not called after the first spec causing all CDP events to be ignored. In order to resolve the issue, we callprotocolManager.connectToBrowser
before the subsequent specs are run.Steps to test
Run multiple CT specs and verify the CDP events are captured.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?