Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support experimentalSingleTabRunMode in protocol #27659

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Aug 25, 2023

Additional details

  • When experimentalSingleTabRunMode is enabled, the same tab is used for multiple specs. As such, the protocolManager.connectToBrowser method is not called after the first spec causing all CDP events to be ignored. In order to resolve the issue, we call protocolManager.connectToBrowser before the subsequent specs are run.
  • Moved the protocol system-tests to their own project and added CT tests.

Steps to test

Run multiple CT specs and verify the CDP events are captured.

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Aug 25, 2023

Passing run #50498 ↗︎

0 634 1 0 Flakiness 0

Details:

Merge branch 'release/13.0.0' into mschile/protocol/single_tab_run_mode
Project: cypress Commit: cccc7c037a
Status: Passed Duration: 07:30 💡
Started: Aug 25, 2023 9:38 PM Ended: Aug 25, 2023 9:45 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Collaborator

@ryanthemanuel ryanthemanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the above suggestion

packages/server/test/unit/browsers/browsers_spec.js Outdated Show resolved Hide resolved
system-tests/projects/protocol/cypress/support/commands.ts Outdated Show resolved Hide resolved
system-tests/test/protocol_spec.js Outdated Show resolved Hide resolved
system-tests/projects/protocol/tsconfig.json Outdated Show resolved Hide resolved
system-tests/projects/protocol/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good besides the system-test failures. We should be g2g once those are fixed

@mschile mschile merged commit 5fe9473 into release/13.0.0 Aug 25, 2023
@mschile mschile deleted the mschile/protocol/single_tab_run_mode branch August 25, 2023 21:48
@cypress cypress bot mentioned this pull request Aug 25, 2023
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants