Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes url validation error on artifact report #27671

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional details

Properly assigns uploadUrl to url, resolving empty string zod errors

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review August 25, 2023 18:42
@cypress
Copy link

cypress bot commented Aug 25, 2023

29 flaky tests on run #50487 ↗︎

0 28088 1355 0 Flakiness 29

Details:

Merge branch 'release/13.0.0' into cacie/chore/artifact-report-url-error
Project: cypress Commit: 896917e979
Status: Passed Duration: 19:09 💡
Started: Aug 25, 2023 7:48 PM Ended: Aug 25, 2023 8:07 PM
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Output Screenshots
Flakiness  e2e/origin/commands/connectors.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin connectors > .each() Test Replay Output
Flakiness  e2e/origin/logging.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin logging > groups callback commands on a passing test Test Replay Output
Flakiness  e2e/origin/commands/location.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin location > .hash() Test Replay Output
Flakiness  e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin navigation > .go() Test Replay Output

The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. not sure why the proxy spec is failing. my guess is flake?

@cacieprins cacieprins merged commit dc5ebd1 into release/13.0.0 Aug 25, 2023
@cacieprins cacieprins deleted the cacie/chore/artifact-report-url-error branch August 25, 2023 20:41
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants