chore: remove prerequests on request failed events #27674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 flaky tests on run #50532 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found |
Test Replay
Output
Screenshots
|
|
cypress-in-cypress.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config |
Test Replay
Output
Screenshots
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
ryanthemanuel
requested review from
cacieprins,
chrisbreiding,
mjhenkes,
mschile and
AtofStryker
chrisbreiding
approved these changes
Aug 28, 2023
AtofStryker
approved these changes
Aug 28, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Remove prerequests on request failed events. Previously these requests were hanging around and could be potentially be incorrectly correlated with future requests to the same resource.
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?