chore: exclude null highlight elements from protocol snapshot #27685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
approved these changes
Aug 28, 2023
dkasper-was-taken
approved these changes
Aug 28, 2023
8 flaky tests on run #50587 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| delayed navigation > errors > redirects to an unexpected cross-origin and calls another command in the cy.origin command |
Test Replay
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
Review all test suite changes for PR #27685 ↗︎
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Updated the protocol snapshots to exclude any highlight elements that returned null.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?