-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Replacing LayerCI references with webapp.io (finishing previous PR) #28874
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuadsouza What's the intention behind adding the EXPOSE_WEBSITE_HOST
? I don't think this env var is needed. These env vars are primarily surfaced for Cypress use, and we don't have a need for this env var that I can see.
Otherwise this looks good!
Got it, just updated the PR and removed |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
LayerCI has rebranded to webapp.io, context here https://webapp.io/blog/layerci-has-rebranded-to-webapp-io/.
The environment build variables have updated in webapp.io to some new variables (instead of the old ones with reference to LayerCI). Refer to the following documentation in webapp.io with the
environment build variables
This PR finishes up the work done in this previously opened PR https://github.com/cypress-io/cypress/pull/28577/files and also adds in the
EXPOSE_WEBSITE_HOST
build environment variable exposed by webapp.ioSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation
? Updating docs to reflect LayerCI changes to webapp.io cypress-documentation#5632type definitions
?