perf: remove listener to fix log memory leak #29939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mschile Need a changelog entry for performance |
mschile
changed the title
jennifer-shehane
approved these changes
Jul 30, 2024
AtofStryker
approved these changes
Jul 30, 2024
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/protocol/log_memory_leak
|
| Run ID |
|
| Run duration | 23:08 💡 |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
1328
|
Skipped
|
0
|
Passing
|
29312
|
| View all changes introduced in this branch ↗︎ | |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With protocol enabled, we add a
test:after:runlistener but never remove it which causes a memory leak with the log not being garbage collected. In order to fix the issue, I updated the listener to useonceso it gets removed after it's called.Steps to test
Added a test to verify the log isn't flushed multiple times.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?