-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address some accessibility violations #30358
base: develop
Are you sure you want to change the base?
Conversation
@@ -22,7 +22,7 @@ | |||
withDefaults(defineProps<{ | |||
value: boolean | |||
size?: 'sm' | 'md' | 'lg' | 'xl' | |||
name: string // required for an id so that an external <label> can be associated with the switch | |||
labelId: string // required for an id so that an external <label> can be associated with the switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Switch component was built to be used like:
<Switch name="setting" .... />
<label for="setting">Enabled Setting</label>
Everywhere this was used was flagged with the violation buttons must have discernible text
. This seems like it should be valid given it aligns with the suggested markup here.
According to dequelabs/axe-core#3696, this structure is flagged as a violation as it does not play nice with JAWS/IE 11 screen readers and axe supports those browsers.
cypress Run #57476
Run Properties:
|
Project |
cypress
|
Branch Review |
fix-a11y-issues
|
Run status |
Cancelled #57476
|
Run duration | 01m 51s |
Commit |
7e0d776f0b: fixes
|
Committer | Emily Rohrbough |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
1
|
Pending |
311
|
Skipped |
0
|
Passing |
1981
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
42.78%
|
|
---|---|
Untested elements |
198
|
Tested elements |
150
|
Accessibility
93.08%
|
|
---|---|
Failed rules |
5 critical
9 serious
1 moderate
2 minor
|
Failed elements |
842
|
Tests for review
The first 5 failed specs are shown, see all 1093 specs in Cypress Cloud.
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-firefox
Test | Artifacts | |||||||
---|---|---|---|---|---|---|---|---|
cy.origin - cookie login > Max-Age > past max-age -> not logged in |
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
|
Additional details
Resolve the following Accessibility violations:
Steps to test
PR Tasks
cypress-documentation
?type definitions
?