Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address some accessibility violations #30358

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Oct 3, 2024

  • Closes

Additional details

Resolve the following Accessibility violations:

  • ARIA input fields must have an accessible name
  • ARIA toggle fields must have an accessible name
  • Buttons must have discernible text
  • Form Elements must have labels

Steps to test

  • All tests pass
  • the above rules are now passing in the Accessibility reports

PR Tasks

@emilyrohrbough emilyrohrbough changed the title Fix a11y issues chore: address some accessibility violations Oct 3, 2024
@@ -22,7 +22,7 @@
withDefaults(defineProps<{
value: boolean
size?: 'sm' | 'md' | 'lg' | 'xl'
name: string // required for an id so that an external <label> can be associated with the switch
labelId: string // required for an id so that an external <label> can be associated with the switch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Switch component was built to be used like:

<Switch name="setting" .... />
<label for="setting">Enabled Setting</label>

Everywhere this was used was flagged with the violation buttons must have discernible text. This seems like it should be valid given it aligns with the suggested markup here.

According to dequelabs/axe-core#3696, this structure is flagged as a violation as it does not play nice with JAWS/IE 11 screen readers and axe supports those browsers.

Copy link

cypress bot commented Oct 3, 2024

cypress    Run #57476

Run Properties:  status check cancelled Cancelled #57476  •  git commit 7e0d776f0b: fixes
Project cypress
Branch Review fix-a11y-issues
Run status status check cancelled Cancelled #57476
Run duration 01m 51s
Commit git commit 7e0d776f0b: fixes
Committer Emily Rohrbough
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 311
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1981
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  42.78%
  Untested elements 198  
  Tested elements 150  
Accessibility  93.08%
  Failed rules  5 critical   9 serious   1 moderate   2 minor
  Failed elements 842  

Tests for review

Failed  config-warning.cy.ts • 0 failed tests • launchpad-e2e

View Output

Test Artifacts
Failed  project-setup.cy.ts • 0 failed tests • launchpad-e2e

View Output

Test Artifacts
Failed  config-files-error-handling.cy.ts • 0 failed tests • launchpad-e2e

View Output

Test Artifacts
Failed  open-mode.cy.ts • 0 failed tests • launchpad-e2e

View Output

Test Artifacts
Failed  global-mode.cy.ts • 0 failed tests • launchpad-e2e

View Output

Test Artifacts

The first 5 failed specs are shown, see all 1093 specs in Cypress Cloud.

Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not logged in
    </td>
  </tr></table>
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/57476/overview/9aed0e96-27c3-4a5b-b35e-8232da8782b8?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/57476/overview/594ab111-f4d4-4bdd-a54e-48e935bbb107?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant