breaking: dropping support for webpack-dev-server 3 from @cypress/webpack-dev-server and make @cypress/webpack-dev-server ship with webpack-dev-server version 5 by default (from 4)
#30467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
breaking/remove_wds3_from_cypress_webpack_dev_server
branch
from
1436bbb to
1987422
Compare
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_wds3_from_cypress_webpack_dev_server
|
| Run status |
|
| Run duration | 17m 11s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
110
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
AtofStryker
force-pushed
the
breaking/remove_wds3_from_cypress_webpack_dev_server
branch
from
925a654 to
dca2184
Compare
AtofStryker
changed the title
@cypress/webpack-dev-server ship with webpack-dev-server version 5 by default (from 4)
AtofStryker
commented
Oct 29, 2024
| @@ -3,8 +3,8 @@ import type { fixtureDirs } from '@tooling/system-tests' | |||
| type ProjectDirs = typeof fixtureDirs | |||
|
|
|||
| const PROJECTS: {projectName: ProjectDirs[number], test: string}[] = [ | |||
| // TODO: Flaky { projectName: 'angular-14', test: 'app.component' }, | |||
| // TODO: Flaky. { projectName: 'vueclivue2-configured', test: 'HelloWorld.cy' }, | |||
| { projectName: 'angular-18', test: 'app.component' }, | |||
There was a problem hiding this comment.
these are going to churn a bit over the next few PRs related to CT 😅
AtofStryker
commented
Oct 29, 2024
| @@ -209,7 +209,8 @@ describe('component testing dependency warnings', () => { | |||
| cy.get('.warning-markdown').find('li').should('have.length', 3) | |||
| }) | |||
|
|
|||
| it('warns against outdated @vue/cli dependency', () => { | |||
| // TODO: make this version of @vue/cli-service 5 in https://github.com/cypress-io/cypress/issues/30295 or related issue | |||
There was a problem hiding this comment.
this test will probably get deleted since we are removing @vue/cli-service support entirely, but we need to support vue with webpack. scaffolding tbd
AtofStryker
commented
Oct 29, 2024
| @@ -9,7 +9,8 @@ | |||
| "css-loader": "^4.3.0", | |||
| "style-loader": "^2.0.0", | |||
| "vite": "^2.8.0", | |||
| "webpack": "^4" | |||
| "webpack": "^4", | |||
| "webpack-dev-server": "^4" | |||
There was a problem hiding this comment.
now needed since we use webpack 4 in this project. updates on this project/system test will happen at a later time
| } | ||
| } | ||
| ], | ||
| "responseEndedWithEmptyBody": [], |
There was a problem hiding this comment.
@AtofStryker Why did this change?
There was a problem hiding this comment.
I can't say for certain, but my best guess, which is what I assumed, is that the response from webpack-dev-server v5 is different from that from v4 since it is what is serving the HelloMars.cy.jsx file. We could know for certain if we install wds 4 in protocol system test package and see if the response body is there
…pack-dev-server
BREAKING CHANGE: support for webpack-dev-server version 3 has been removed. webpack-dev-server 3 is no longer maintained by the webpack team. To reduce overhead, Cypress is now removing support in Cypress 14.
… which does not work with webpack 4)
… which does not work with webpack 4)
… well as skip config warning for outdated vuecli3 as it will throw due to wds being on version 3. this is a VERY old version, and the test needs to be updated to use vuecli5 so we get wds v5 (vuecli5 support will be deprecated)
…er supported [run ci]
…-server 4, which is now a dev dependency [run ci]
AtofStryker
force-pushed
the
breaking/remove_wds3_from_cypress_webpack_dev_server
branch
from
dca2184 to
c40d117
Compare
AtofStryker
added
the
npm: @cypress/webpack-dev-server
cacieprins
approved these changes
Oct 30, 2024
jennifer-shehane
approved these changes
Oct 30, 2024
ryanthemanuel
approved these changes
Oct 30, 2024
AtofStryker
deleted the
breaking/remove_wds3_from_cypress_webpack_dev_server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack-dev-server4.7.0 or later #30141Additional details
Removes support for
webpack-dev-server(wds) version 3 from@cypress/webpack-dev-server. Because we no longer support wds 3, that means we no longer support:create-react-appversion 4 (last released 4 years ago)@vue/cli-serviceversion 4 (last released 2 years ago).@vue/cli-serviceis no longer recommended by the vue team, but if being used@vue/cli-serviceversion 5 is the current, which uses webpack-dev-server 4.create-react-appand@vue/cli-servicesupport will be removed in Cypress 14 in issues #30028 and #30481. This is just a precursor to that work since we cant support the older versions here any longer. In the meantime, affected system tests have been updated to latest dependencies (that aren't specifically testing an older version of a dependency).This PR also bumps
webpack-dev-servershipped version in@cypress/webpack-dev-serverto version 5. Users still onwebpack4 will need to installwebpack-dev-serverversion 4 along side cypress to continue running component tests.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?