#3845 Attempt to add insert, page up and page down keys #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We'll want to open a PR for the documentation to add these to the special chars table upon release. https://github.com/cypress-io/cypress-documentation/blob/develop/source/api/commands/type.md |
kuceb
previously requested changes
Apr 8, 2019
|
@jennifer-shehane I have created a PR on cypress-documentation for these 3 new keys. |
jennifer-shehane
approved these changes
Apr 10, 2019
|
@jennifer-shehane is saying that the browser respects the default behavior of pageup + pagedown which is hard to believe... but regardless there should be a test ensuring that this is correctly happening. |
laurinenas
pushed a commit
to laurinenas/cypress
that referenced
this pull request
Apr 28, 2019
…press-io#3892) * Attempt to add insert, page up and page down keys. * Fix keyboard event for page down. Fix tests' titles. * Fix the pagedown test. * Fix comment for the insert key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my attempt to add the support for the insert, page up and page down keys. I've used the PR for #3071 as a guide.
Please feel free to comment on this PR. I think that these keys behave in a similar way as the escape key: They don't change the input or the cursor's location.
Close #3845.