address #3069 by using chokidar fs events #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@chrisbreiding any chance you can review this? I’d love to see it make 3.3.0 since it solves a daily drag for all our developers. |
|
@jennifer-shehane we are paying subscribers, is there a chance this Pr can be reviewed? |
|
@lukeapage It's my next priority to take a look at this. We should be able to get it out with 3.3.0 |
the watchers lib watches for file contents changing and doesn’t watch for files being added or removed
chrisbreiding
approved these changes
May 7, 2019
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3069
Globbing for spec changes on a large codebase may take longer than the hard-coded interval of 2500ms, as specified in #3069
Using fs events from chokidar partially addresses this problem by only scanning for spec changes when the watcher sees changes, rather than polling.
#3069 (comment)