Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cy.clearCookie, fix HTTP redirect behavior, fix cy.visit HTTPS baseurl behavior #5478

Merged
merged 33 commits into from
Nov 8, 2019
Merged

Fix cy.clearCookie, fix HTTP redirect behavior, fix cy.visit HTTPS baseurl behavior #5478

merged 33 commits into from
Nov 8, 2019

Commits on Oct 25, 2019

  1. Add a bunch of extra tests in 2_cookies_spec

    @flotwig
    flotwig committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    2743311 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Try not doing weird things to cookies

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    23a68f9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into issue-5433-fix-cle… 

    …arcookie
    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    0b4c3a4 View commit details
    Browse the repository at this point in the history

  3. if cypress.env.debug is set, log command execution thru server

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    623ed44 View commit details
    Browse the repository at this point in the history

  4. improve elctron logging - we missed this when doing cri-client logging

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    0d409f9 View commit details
    Browse the repository at this point in the history

  5. make video_capture frames part of verbose

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    800bd00 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    7cacaef View commit details
    Browse the repository at this point in the history

  7. use the data from getCookie to run deleteCookies

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    33033c3 View commit details
    Browse the repository at this point in the history

  8. fix screenshots

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    2feec55 View commit details
    Browse the repository at this point in the history

  9. still resolve with cleared cookie

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    f6c74b0 View commit details
    Browse the repository at this point in the history

  10. cy.getcookie now gets ALL cookies from ALL domains

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    4ce8f22 View commit details
    Browse the repository at this point in the history

  11. return Promise for followRedirect, not req.init wrap

    @flotwig
    flotwig committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    7c0304f View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. allow passing domain: null to cy.getCookies to get all

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    677d3b0 View commit details
    Browse the repository at this point in the history

  2. update request_spec to be clearer

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    b9276b8 View commit details
    Browse the repository at this point in the history

  3. still need to call followRedirect option during sendStream

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    69b9bb5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into issue-5433-fix-clearcookie

    @flotwig
    flotwig authored Nov 5, 2019
    Configuration menu
    Copy the full SHA
    2c70fcc View commit details
    Browse the repository at this point in the history

  5. beautify the e2e tests

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    328788b View commit details
    Browse the repository at this point in the history

  6. correct e2e test + snapshot

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    d5b0721 View commit details
    Browse the repository at this point in the history

  7. always discard default ports when get/set buffer - fixes #5367

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    ff2d9df View commit details
    Browse the repository at this point in the history

  8. make cy.clearCookies({ domain: null }) clear ALL cookies

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    9ee7596 View commit details
    Browse the repository at this point in the history

  9. update spec

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    9fa782a View commit details
    Browse the repository at this point in the history

  10. use string url as key

    @flotwig
    flotwig committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    3a5f5fe View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. rebalance some e2e tests to make time for new cookies e2e tests

    @flotwig
    flotwig committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    43560f1 View commit details
    Browse the repository at this point in the history

  2. always add default port to buffer url

    @flotwig
    flotwig committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    f2e8dd6 View commit details
    Browse the repository at this point in the history

  3. jk, remove default port

    @flotwig
    flotwig committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    768caf6 View commit details
    Browse the repository at this point in the history

  4. set hostOnly: true when appropriate when setting cookies back on visit

    @flotwig
    flotwig committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    5907b3f View commit details
    Browse the repository at this point in the history

  5. update tests

    @flotwig
    flotwig committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    83e0b01 View commit details
    Browse the repository at this point in the history

  6. Revert "if cypress.env.debug is set, log command execution thru server" 

    This reverts commit 623ed44.
    @flotwig
    flotwig committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    12ed0c2 View commit details
    Browse the repository at this point in the history

  7. try to clean diff, cookies_no_baseurl didnt change

    @flotwig
    flotwig committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    4b6b7e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. WIP move the expected cookies array out of snapshot and expect inline

    @brian-mann
    brian-mann committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    17de471 View commit details
    Browse the repository at this point in the history

  2. finish updating tests

    @flotwig
    flotwig committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    d324492 View commit details
    Browse the repository at this point in the history

  3. add missing snapshot

    @flotwig
    flotwig committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    9ea62f4 View commit details
    Browse the repository at this point in the history

  4. remove useless onstdout

    @flotwig
    flotwig authored Nov 7, 2019
    Configuration menu
    Copy the full SHA
    7f33376 View commit details
    Browse the repository at this point in the history