Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cy.type in hidden inputs, contenteditable selections #5865

Merged
merged 10 commits into from
Dec 4, 2019
Merged

fix: cy.type in hidden inputs, contenteditable selections #5865

merged 10 commits into from
Dec 4, 2019

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Dec 3, 2019 •
edited
Loading

fix #5835 cy.type with force:true on hidden inputs (regression from 3.5.0)
fix cy.type in contenteditable with selections (regression from #5854 develop, unreleased)

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 3, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Dec 3, 2019


Test summary

3541 • 0 • 45 • 0

Run details
Project cypress
Status Passed
Commit 967a048
Started Dec 3, 2019 8:14 PM
Ended Dec 3, 2019 8:18 PM
Duration 03:49 💡
OS Linux Debian - 9.8
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

kuceb
kuceb commented Dec 3, 2019
View reviewed changes
packages/driver/test/cypress/integration/commands/actions/type_spec.js
@@ -2157,14 +2234,6 @@ describe('src/cy/commands/actions/type', () => {
it('correct events in contenteditable', () => {
const ce = cy.$$('[contenteditable]:first')

const keydown = cy.stub().callsFake((e) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was redundant, tested above already

@kuceb kuceb requested review from brian-mann and jennifer-shehane and removed request for brian-mann December 3, 2019 20:37
jennifer-shehane
jennifer-shehane reviewed Dec 4, 2019
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the code here does fix the issue originally opened.

bahmutov
bahmutov approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, and if it fixes Piechopper than it is good to fix develop

@bahmutov bahmutov merged commit 6ed8d31 into develop Dec 4, 2019
@cypress-bot cypress-bot bot mentioned this pull request Dec 4, 2019
Closed
avallete pushed a commit to avallete/cypress that referenced this pull request Dec 10, 2019
@kuceb
fix: cy.type in hidden inputs, contenteditable selections (cypress-io…
c77a979 
…#5865)

* fix type when previous selection in input

* cleanup

* cleanup more

* more cleanup

* more more cleanup final

* fix not firing input event in all cases

* fix deletion with selection in contenteditables + tests

* remove only

* fix hidden input selections
@emilyrohrbough emilyrohrbough deleted the focus-selection-type-3-6-1 branch August 1, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane left review comments

@bahmutov bahmutov bahmutov approved these changes

@brian-mann brian-mann Awaiting requested review from brian-mann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cy.clear({ force: true }) only deletes first character of hidden input in 3.5.0
3 participants
@kuceb @jennifer-shehane @bahmutov