Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cy.viewport limits #5901

Merged
merged 4 commits into from
Dec 9, 2019
Merged

fix: remove cy.viewport limits #5901

merged 4 commits into from
Dec 9, 2019

Conversation

jabczyk
Copy link
Contributor

@jabczyk jabczyk commented Dec 6, 2019

User facing changelog

Removed 20px-8000px bounds for cy.viewport(). It now supports range from 0 to any finite number.

Additional details

  • Tracking pixel tests don't need a 20x20px viewport. 0x0px is enough.
  • Large viewports don't seem to cause any performance issues, so there's no need to prevent them.

How has the user experience changed?

Users are now able to create 0x0px viewports.

// before 
cy.viewport(20, 20)
cy.visit('tracking-pixel-page')

// after
cy.viewport(0, 0)
cy.visit('tracking-pixel-page')

Users are now able to test applications with huge UI.

cy.viewport(5 * 1920, 1080)

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@claassistantio
Copy link

claassistantio commented Dec 6, 2019

CLA assistant check
All committers have signed the CLA.

@flotwig flotwig self-requested a review December 6, 2019 18:10
@flotwig
Copy link
Contributor

flotwig commented Dec 6, 2019

Was curious what this looked like.

0x0 viewport:
image

100k x 100k viewport:
image

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! These changes look good, but this will also need a PR in cypress-documentation to update the cy.viewport docs: https://docs.cypress.io/api/commands/viewport.html

@flotwig flotwig merged commit 48e7c0e into cypress-io:develop Dec 9, 2019
@jabczyk jabczyk deleted the issue-5892 branch December 9, 2019 15:48
avallete pushed a commit to avallete/cypress that referenced this pull request Dec 10, 2019
* fix(driver): remove cy.viewport limits

* test(driver): update tests for cy.viewport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove upper limit on cy.viewport; investigate removing lower limit
3 participants