-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove cy.viewport limits #5901
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! These changes look good, but this will also need a PR in cypress-documentation to update the cy.viewport
docs: https://docs.cypress.io/api/commands/viewport.html
* fix(driver): remove cy.viewport limits * test(driver): update tests for cy.viewport
User facing changelog
Removed 20px-8000px bounds for
cy.viewport()
. It now supports range from 0 to any finite number.Additional details
How has the user experience changed?
Users are now able to create 0x0px viewports.
Users are now able to test applications with huge UI.
PR Tasks