Update browser types

[flotwig]

• Closes Update browser types, adding channel and making names consistent #6243

User facing changelog

• Updated Cypress browser objects with a new field, channel, which contains the release channel of the detected browser.
• Changed the family of all Chromium-based browsers, including Electron, to chromium.
• cypress run --browser can now be used to specify a specific release channel of a browser, for example, chrome:canary to select Canary.

Additional details

• Replace all checks for family == 'chrome' with family == 'chromium'
• Replace all checks for family == 'electron' with name == 'electron'
• Update --browser arg passing to allow name:channel
• Update 'electron' static browser definition - maybe move into TS
• fix browser icons

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation? Update docs for browser type changes cypress-documentation#2454
• Have API changes been updated in the type definitions?
• [n/a] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3632 • 0 • 46 • 0

---

Run details

Project	cypress
Status	Passed
Commit	a89b23f
Started	Jan 31, 2020 5:50 PM
Ended	Jan 31, 2020 5:55 PM
Duration	04:43 💡
OS	Linux Debian - 9.11
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

Have you considered Edge against these changes? It has the family set to chrome for Edge and I wasn't sure if this is what was agreed upon with what y'all have planned. https://github.com/cypress-io/cypress/pull/6181/files#diff-8b47f6bfe0325f7e2f8c5dad78954073R41

[flotwig]

Have you considered Edge against these changes? It has the family set to chrome for Edge and I wasn't sure if this is what was agreed upon with what y'all have planned. cypress-io/cypress/pull/6181/files#diff-8b47f6bfe0325f7e2f8c5dad78954073R41

Yeah, see the original issue #6243, it will have a family of chromium.

[brian-mann]

Preliminary review of this looks good