-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix path typo for chromium mac #6358
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
We're going to need some tests around this - or some sort of general testing strategy for browser paths in general since this is a recurring theme in the 4.0 release now, not detecting the correct MacOS path. |
Sure thing, happy to contribute, how are you thinking on approaching it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open a PR to add tests for the Darwin launcher, but for now this looks good. Thanks @obartra !
Closes #6357
User facing changelog
correct path for detecting Chromium on MacOS
Additional details
How has the user experience changed?
PR Tasks