Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using Chromium installed via snapcraft #7039

Merged
merged 6 commits into from
Apr 20, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Apr 16, 2020

User facing changelog

  • Fixed a bug preventing Cypress from launching on systems where Chromium was installed via Snapcraft.

Additional details

  • in cypress open, project would never load and spinner would run forever. on cypress run, no output is printed to the console (browser detection runs before anything is printed)
  • mysteriously, execa would hang on --version when used with the snap
  • switched to using cp instead since execa is only really used for windows benefits and it works fine
  • added a 5s timeout to getVersionString since it should never take that long
  • still having issue due to snap sandboxing, cannot create browser profile: Launch Hanging on Ubuntu when snap version of Chromium is installed #7020 (comment)
    • instead of writing to the usual appdata dir, write to $HOME/snap/chromium/current/Cypress since that's the only place this chromium can write
    • tested locally, would also like @bkucera to test on his system

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 16, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Apr 16, 2020



Test summary

7178 0 98 0


Run details

Project cypress
Status Passed
Commit f2809ea
Started Apr 17, 2020 2:13 PM
Ended Apr 17, 2020 2:19 PM
Duration 06:06 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig requested a review from kuceb April 16, 2020 21:24
@flotwig flotwig changed the title [WIP] Fix using Chromium installed via snapcraft Fix using Chromium installed via snapcraft Apr 17, 2020
@flotwig flotwig requested review from kuceb and jennifer-shehane and removed request for kuceb April 17, 2020 14:32
@kuceb
Copy link
Contributor

kuceb commented Apr 17, 2020

verified this works for me. After installing snap chromium cypress hangs. with these changes it's fixed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch Hanging on Ubuntu when snap version of Chromium is installed
3 participants