Merge pull request #182 from MikeMcC399/convert-to-sourcecode

fix: convert deprecated context calls
cypress-io · Apr 26, 2024 · 429ac7f · 429ac7f
2 parents 21c8bd2 + 534db69
commit 429ac7f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/lib/rules/no-async-before.js b/lib/rules/no-async-before.js
@@ -28,11 +28,14 @@ module.exports = {
                 && node.arguments.length >= 2
                 && node.arguments[1].async === true
     }
+    const sourceCode = context.sourceCode ?? context.getSourceCode()
 
     return {
       Identifier (node) {
         if (node.name === 'cy' || node.name === 'Cypress') {
-          const ancestors = context.getAncestors()
+          const ancestors = sourceCode.getAncestors
+            ? sourceCode.getAncestors(node)
+            : context.getAncestors()
           const asyncTestBlocks = ancestors
           .filter((n) => n.type === 'CallExpression')
           .filter(isBeforeBlock)

diff --git a/lib/rules/no-async-tests.js b/lib/rules/no-async-tests.js
@@ -28,11 +28,14 @@ module.exports = {
                 && node.arguments.length >= 2
                 && node.arguments[1].async === true
     }
+    const sourceCode = context.sourceCode ?? context.getSourceCode()
 
     return {
       Identifier (node) {
         if (node.name === 'cy' || node.name === 'Cypress') {
-          const ancestors = context.getAncestors()
+          const ancestors = sourceCode.getAncestors
+            ? sourceCode.getAncestors(node)
+            : context.getAncestors()
           const asyncTestBlocks = ancestors
           .filter((n) => n.type === 'CallExpression')
           .filter(isTestBlock)

diff --git a/lib/rules/no-unnecessary-waiting.js b/lib/rules/no-unnecessary-waiting.js
@@ -15,10 +15,14 @@ module.exports = {
     },
   },
   create (context) {
+    const sourceCode = context.sourceCode ?? context.getSourceCode()
+
     return {
       CallExpression (node) {
         if (isCallingCyWait(node)) {
-          const scope = context.getScope()
+          const scope = sourceCode.getScope
+            ? sourceCode.getScope(node)
+            : context.getScope()
 
           if (isIdentifierNumberConstArgument(node, scope) || isNumberArgument(node)) {
             context.report({ node, messageId: 'unexpected' })