fix: Fix no-assigning-return-values no callee exception (fixes #8)

cypress-io · Nov 8, 2018 · a007ecc · a007ecc
1 parent 13ff374
commit a007ecc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/rules/no-assigning-return-values.js b/lib/rules/no-assigning-return-values.js
@@ -40,6 +40,9 @@ function isCypressCommandDeclaration(declarator) {
 
   while (object.callee) {
     object = object.callee.object;
+    if (!object) {
+      return;
+    }
   }
 
   return object.name === 'cy';

diff --git a/tests/lib/rules/no-assigning-return-values.js b/tests/lib/rules/no-assigning-return-values.js
@@ -14,6 +14,7 @@ ruleTester.run('no-assigning-return-values', rule, {
     { code: 'let foo = true;', parserOptions },
     { code: 'const foo = true;', parserOptions },
     { code: 'const foo = bar();', parserOptions },
+    { code: 'const foo = bar().baz();', parserOptions },
     { code: 'cy.get("foo");', parserOptions },
     { code: 'cy.contains("foo").click();', parserOptions }
   ],