-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rule documentation harmonization #198
Merged
jennifer-shehane
merged 4 commits into
cypress-io:master
from
MikeMcC399:rule-doc-harmonization
Apr 30, 2024
Merged
docs: rule documentation harmonization #198
jennifer-shehane
merged 4 commits into
cypress-io:master
from
MikeMcC399:rule-doc-harmonization
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jennifer-shehane
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for standardizing this. It's much better.
It's taking shape bit by bit! Thanks for merging! |
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This PR deals with issues in the set of 9 docs/rules Markdown files.
docs/rules
documents do not agree with the lib/rules propertymeta.docs.description
.docs/rules
documents is inconsistent.Changes
docs/rules
documents are built using themeta.docs.description
property from the corresponding lib/rules source.docs/rules
top-level header has the name of the rule in the form(cypress/<rule-name>)
consistently appended.Comments
This PR only aims to restructure existing information.
There is scope for further improvement of rule documents by adding content. For instance, the docs/rules/no-unnecessary-waiting.md essentially contains only a link to the Cypress documentation site without providing any other description or summary. This could optionally be covered in a later PR.
Due to issues with the document generator incorrectly duplicating headers in some situations, the planned PR to add the npm module eslint-doc-generator is held back for the time being. The issues have been reported and PR OS-agnostic handling of end-of-line characters bmish/eslint-doc-generator#524 plans to address.