-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix set-output command warnings from GitHub #621
Conversation
@piotrekkr This PR calls out addressing the |
@mellis481 It should also fix this set-state warning. Check release notes here https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#1100 |
Any updated on this issue? |
@admah Hello. Seems like you are able to merge pull request in this project so can you take a look and merge this PR? Thanks. |
@piotrekkr Thank you for your work! @mjhenkes @bahmutov Could you please help move this along? It would be great to resolve the warnings from github actions: |
@piotrekkr thanks for the PR! |
@mjhenkes Thanks for merging this. For now we should use master version for github action right? When do you plan on releasing new version with this fix? |
@piotrekkr The release is normally triggered by the merge to master but the commit message was missing the ":" as part of the semantic-commit convention. Didn't spot that before the merge so I just kicked off a release manually. |
@piotrekkr I'm testing this change in one of my workflows now and the problem appears to still exist. FWIW, I still see CC: @jaffrepaul @mjhenkes |
The PR didnt rebuild the action dist files..only updated the version. you may need another PR to build the runnable artefacts |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v4.2.0` -> `v4.2.1` | | [ruby/setup-ruby](https://togithub.com/ruby/setup-ruby) | action | minor | `v1.123.0` -> `v1.124.0` | --- ### Release Notes <details> <summary>cypress-io/github-action</summary> ### [`v4.2.1`](https://togithub.com/cypress-io/github-action/releases/tag/v4.2.1) [Compare Source](https://togithub.com/cypress-io/github-action/compare/v4.2.0...v4.2.1) ##### Bug Fixes - **deps:** fix set-output command warnings from GitHub [https://github.com/cypress-io/github-action/pull/621](https://togithub.com/cypress-io/github-action/pull/621)/commits/a66d9963a59d417607160127678cba80faf72cf4 </details> <details> <summary>ruby/setup-ruby</summary> ### [`v1.124.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.124.0): Ignore Bundler dev version in Gemfile.lock [Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.123.0...v1.124.0) - Fixes [https://github.com/ruby/setup-ruby/issues/394](https://togithub.com/ruby/setup-ruby/issues/394) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach). PR-URL: #70 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jaffrepaul @mellis481 @lwhiteley I did not know that I should rebuild dist. Not sure where it is in docs. Anyway fix is here: #638 |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v4.2.0` -> `v4.2.1` | | [ruby/setup-ruby](https://togithub.com/ruby/setup-ruby) | action | minor | `v1.123.0` -> `v1.124.0` | --- ### Release Notes <details> <summary>cypress-io/github-action</summary> ### [`v4.2.1`](https://togithub.com/cypress-io/github-action/releases/tag/v4.2.1) [Compare Source](https://togithub.com/cypress-io/github-action/compare/v4.2.0...v4.2.1) ##### Bug Fixes - **deps:** fix set-output command warnings from GitHub [https://github.com/cypress-io/github-action/pull/621](https://togithub.com/cypress-io/github-action/pull/621)/commits/a66d9963a59d417607160127678cba80faf72cf4 </details> <details> <summary>ruby/setup-ruby</summary> ### [`v1.124.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.124.0): Ignore Bundler dev version in Gemfile.lock [Compare Source](https://togithub.com/ruby/setup-ruby/compare/v1.123.0...v1.124.0) - Fixes [https://github.com/ruby/setup-ruby/issues/394](https://togithub.com/ruby/setup-ruby/issues/394) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach). PR-URL: #70 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fixes #613