Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update failed tests #643

Merged
merged 4 commits into from
Dec 7, 2022
Merged

fix: update failed tests #643

merged 4 commits into from
Dec 7, 2022

Conversation

jaffrepaul
Copy link
Contributor

@jaffrepaul jaffrepaul commented Dec 2, 2022

Targeting a few failing tests that have been part of the previous GHA releases with some fixes.

There are related open issues #1, #2, #3 with FF that still cause flake in one test that will need a separate effort.

@jaffrepaul jaffrepaul marked this pull request as draft December 2, 2022 21:11
@jaffrepaul jaffrepaul changed the title update action vesrions to latest Fix failed tests Dec 2, 2022
@jaffrepaul jaffrepaul marked this pull request as ready for review December 2, 2022 22:28
@jaffrepaul jaffrepaul requested a review from a team December 2, 2022 22:28
@jaffrepaul jaffrepaul changed the title Fix failed tests fix: update failed tests Dec 5, 2022
@MikeMcC399
Copy link
Collaborator

@jaffrepaul

I see you are making good progress on eliminating some of the issues here! Whilst I was trying to find out what was going on with the Node.js issue I noticed that the deprecated ubuntu-18.04 is still in use. It would probably overload this PR if you put additional changes in here, so instead I opened a new issue #648. Perhaps you already had something planned here anyway?

@jaffrepaul jaffrepaul merged commit ced9ddd into master Dec 7, 2022
@MikeMcC399
Copy link
Collaborator

@jaffrepaul

This was 99% successful (110 of 111 checks passed) 👍🏻
Was the remaining failure just the flaky Firefox test you referred to?

BTW: Would you consider making your (presumed) membership of the https://github.com/cypress-io organization visible? See GitHub help Publicizing or hiding organization membership.

@jaffrepaul
Copy link
Contributor Author

@MikeMcC399 Yes, see the original PR message above. Good call on the org visibility ✅ I merged this without making a release yet because I'd like to add some of the additional dependency updates as well first.

@MikeMcC399
Copy link
Collaborator

@jaffrepaul

Good call on the org visibility ✅

Thank you for enabling this!

I merged this without making a release yet because I'd like to add some of the additional dependency updates as well first.

That makes sense. Different workflows need to be updated and the README documentation as well, which will probably take several steps. Once everything is updated and consistent it would be worthwhile declaring a release. Anybody who is subscribed to releases would then get notified. Most users won't need to know about individual updates.

@github-actions
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot referenced this pull request in weareinreach/InReach Dec 20, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://github.com/actions/checkout) | action | digest | `7dd9e2a` -> `755da8c` |
| [chromaui/action](https://github.com/chromaui/action) | action | digest | `0ec8cd8` -> `2440d35` |
| [cypress-io/github-action](https://github.com/cypress-io/github-action) | action | patch | `v5.0.0` -> `v5.0.2` |
| [github/codeql-action](https://github.com/github/codeql-action) | action | digest | `a669cc5` -> `959cbb7` |
| [tinkurlab/monorepo-pr-labeler-action](https://github.com/tinkurlab/monorepo-pr-labeler-action) | action | patch | `4.1.2` -> `4.1.3` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.2`](https://github.com/cypress-io/github-action/releases/tag/v5.0.2)

[Compare Source](https://github.com/cypress-io/github-action/compare/v5.0.1...v5.0.2)

Numerous housekeeping updates to bring this action back up to speed.

\*In combination with v5.0.1, which triggered without a new dist build.

👏 Special thanks to [@&#8203;MikeMcC399](https://github.com/MikeMcC399) for all the diligent work! 👏

**Fix Failed Tests**

-   [https://github.com/cypress-io/github-action/pull/643](https://github.com/cypress-io/github-action/pull/643)
-   [https://github.com/cypress-io/github-action/pull/658](https://github.com/cypress-io/github-action/pull/658)
-   [https://github.com/cypress-io/github-action/pull/660](https://github.com/cypress-io/github-action/pull/660)

**Update Dependencies**

-   [https://github.com/cypress-io/github-action/pull/644](https://github.com/cypress-io/github-action/pull/644)
-   [https://github.com/cypress-io/github-action/pull/650](https://github.com/cypress-io/github-action/pull/650)

**Resolve Warnings**

-   [https://github.com/cypress-io/github-action/pull/651](https://github.com/cypress-io/github-action/pull/651)
-   [https://github.com/cypress-io/github-action/pull/666](https://github.com/cypress-io/github-action/pull/666)
-   [https://github.com/cypress-io/github-action/pull/670](https://github.com/cypress-io/github-action/pull/670)
-   [https://github.com/cypress-io/github-action/pull/675](https://github.com/cypress-io/github-action/pull/675)

**Docs/Example Updates**

-   [https://github.com/cypress-io/github-action/pull/665](https://github.com/cypress-io/github-action/pull/665)
-   [https://github.com/cypress-io/github-action/pull/668](https://github.com/cypress-io/github-action/pull/668)

**Tooling Updates:**

-   [https://github.com/cypress-io/github-action/pull/667](https://github.com/cypress-io/github-action/pull/667)
-   [https://github.com/cypress-io/github-action/pull/677](https://github.com/cypress-io/github-action/pull/677)

### [`v5.0.1`](https://github.com/cypress-io/github-action/releases/tag/v5.0.1)

[Compare Source](https://github.com/cypress-io/github-action/compare/v5.0.0...v5.0.1)

##### Bug Fixes

-   correct .gitignore for videos and screenshots ([89e59e5](https://github.com/cypress-io/github-action/commit/89e59e5cfc7760513fe9e9ce4c690345d94eb27a))

</details>

<details>
<summary>tinkurlab/monorepo-pr-labeler-action</summary>

### [`v4.1.3`](https://github.com/TinkurLab/monorepo-pr-labeler-action/releases/tag/4.1.3): Monorepo PR Labeler v4.1.3

[Compare Source](https://github.com/tinkurlab/monorepo-pr-labeler-action/compare/4.1.2...4.1.3)

Changes include:

Bug fix to ignore directories starting with a dot `.` but not directories that contain a dot `.`. According to the docs, this action should ignore mono repos that begin with a dot but it currently ignores also mono repo with a dot even if it is not the first character. Thanks to [@&#8203;MoLow](https://github.com/MoLow) for the fix!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #107
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jaffrepaul jaffrepaul deleted the fix-failed-tests branch January 5, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants