Correct log format for start: parameter #785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a log formatting issue when the start: (server) parameter is used.
If a step:
is defined in a GitHub workflow, the log would show:
with the text of the start command incorrectly rendered twice.
The fix is credited to @fbiville who originally submitted PR #481 in Jan, 2022.
With this PR the log output for the above example shows as:
Verification
View the logs of https://github.com/cypress-io/github-action/actions/workflows/example-webpack.yml
Select the
wait
job thenCypress tests
.Search for "start server" in the log and confirm that:
is shown.