Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct log format for start: parameter #785

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Feb 10, 2023

This PR resolves a log formatting issue when the start: (server) parameter is used.

If a step:

      - name: Cypress run
        uses: cypress-io/github-action@v5
        with:
          start: npm start

is defined in a GitHub workflow, the log would show:

start server "npm start command "npm start"

with the text of the start command incorrectly rendered twice.

The fix is credited to @fbiville who originally submitted PR #481 in Jan, 2022.

With this PR the log output for the above example shows as:

start server command "npm start"

Verification

View the logs of https://github.com/cypress-io/github-action/actions/workflows/example-webpack.yml

Select the wait job then Cypress tests.

Search for "start server" in the log and confirm that:

start server command "npm start"

is shown.

@MikeMcC399
Copy link
Collaborator Author

Job 7169797661 shows correct rendering:

start server command "npm start"
current working directory "/home/runner/work/github-action/github-action/examples/webpack"
waiting on "http://localhost:8080" with timeout of 60 seconds
/usr/local/bin/npm start

> example-webpack@1.0.0 start
> webpack-dev-server

@jaffrepaul jaffrepaul merged commit 327178c into cypress-io:master Feb 13, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the fix/start_command_log branch February 13, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants