Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageNumber distinction through TableNumber capabilities #59

Closed
wants to merge 66 commits into from

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented May 19, 2023

Description

This PR seeks to address #30, providing a way to differentiate between possible ImageNumber overlaps implementing a "TableNumber" value for tables. TableNumber is a checksum based on the source data file and represents a unique value which will help keep CytoTable output distinct.

Other notable changes in this PR:

  • Increased modularity, spreading work into multiple files for package and tests to help organize and decrease file-level complexity.
  • Added pytest-xdist and default pytest configuration for improved test time performance

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs mentioned this pull request May 23, 2023
13 tasks
@d33bs
Copy link
Member Author

d33bs commented Jul 26, 2023

Closing this in lieu of new requirements and simplified / smaller changes.

@d33bs d33bs closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant