Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epsilon as an option in normalize #128

Closed
shntnu opened this issue Mar 10, 2021 · 0 comments · Fixed by #132
Closed

Add epsilon as an option in normalize #128

shntnu opened this issue Mar 10, 2021 · 0 comments · Fixed by #132

Comments

@shntnu
Copy link
Member

shntnu commented Mar 10, 2021

Include parameter spherize_epsilon in

def normalize(
profiles,
features="infer",
meta_features="infer",
samples="all",
method="standardize",
output_file="none",
compression_options=None,
float_format=None,
spherize_center=True,
spherize_method="ZCA-cor",
):

This line

scaler = Spherize(center=spherize_center, method=spherize_method)

will become

scaler=Spherize(center=spherize_center, method=spherize_method, epsilion=spherize_epsilon)

and that's pretty much it.

We needn't add a test when adding this, but we should test Spherize #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant