Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent unique_cut default value in variance_threshold vs feature_select #282

Closed
alxndrkalinin opened this issue May 17, 2023 · 2 comments

Comments

@alxndrkalinin
Copy link
Contributor

I noticed that variance_threshold always had unique_cut=0.01 as a default, while feature_select later set more strict default unique_cut=0.1, overriding that of variance_threshold.

I'm wondering if this default change was a typo or had a reason and what default setting should suit most projects.

@gwaybio
Copy link
Member

gwaybio commented May 17, 2023

thanks @alxndrkalinin ! I think this is a typo. Feel free to file a PR to keep the default consistent. Most folks invoke variance_threshold through feature_select() so it's probably best to change the default in variance_threshold.

@alxndrkalinin
Copy link
Contributor Author

@gwaybio here you go #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants