You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that variance_thresholdalways hadunique_cut=0.01 as a default, while feature_selectlater set more strict default unique_cut=0.1, overriding that of variance_threshold.
I'm wondering if this default change was a typo or had a reason and what default setting should suit most projects.
The text was updated successfully, but these errors were encountered:
thanks @alxndrkalinin ! I think this is a typo. Feel free to file a PR to keep the default consistent. Most folks invoke variance_threshold through feature_select() so it's probably best to change the default in variance_threshold.
alxndrkalinin
added a commit
to alxndrkalinin/position-effect-correction
that referenced
this issue
May 17, 2023
I noticed that
variance_threshold
always hadunique_cut=0.01
as a default, whilefeature_select
later set more strict defaultunique_cut=0.1
, overriding that ofvariance_threshold
.I'm wondering if this default change was a typo or had a reason and what default setting should suit most projects.
The text was updated successfully, but these errors were encountered: