Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Logo #196

Merged
merged 2 commits into from
May 17, 2022
Merged

Upload Logo #196

merged 2 commits into from
May 17, 2022

Conversation

vincerubinetti
Copy link
Collaborator

image

  • Design logo and create variations in SVG and PNG format.
  • Provide readme for logo.
  • Add logo image to main readme.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🤩

Two comments:

  • I'm getting a 404 error in the README image
  • There's a lot of extra transparency in some of the .svgs (see example below). Is this standard?

Screen Shot 2022-05-17 at 9 26 45 AM

@vincerubinetti
Copy link
Collaborator Author

  • The 404 is because this pr isn't merged yet. I'm just linking to the location of where the logo-with-text file will be when this pr is merged.
  • The SVG doesn't have a defined width or height, and some SVG viewing programs get confused by this and render it as a perfect square. That's probably what's happening here. But don't worry, the viewBox attribute (what defines the boundaries of the image) is cropped correctly to the image. Depending on where and how you end up using the SVG, you may have to finagle some settings or manually define width="" and height="" attributes that match the aspect ratio of the viewBox. I can consult when necessary.

@gwaybio
Copy link
Member

gwaybio commented May 17, 2022

Sounds good! Thanks for checking back in with this detail. I'll go ahead and merge now (cc @niranjchandrasekaran )

@gwaybio gwaybio merged commit 02d0522 into master May 17, 2022
@gwaybio gwaybio deleted the logo branch May 17, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants