Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Memory Performance Within merge_single_cells #197

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Improve Memory Performance Within merge_single_cells #197

merged 3 commits into from
Jun 17, 2022

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented May 20, 2022

Description

This is a change to enhance performance as per #195 . Pandas rename's with copy=False, inplace=False can sometimes see increased performance, as per this reference.

I have not added a test for this as the change is focused on performance that may be variable contingent on the source data and environment involved (memory capacity may fluctuate).

Please let me know if I may make any changes or if you have any questions/concerns. Thank you!

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@bethac07 bethac07 mentioned this pull request Jun 8, 2022
11 tasks
@gwaybio gwaybio mentioned this pull request Jun 8, 2022
@gwaybio gwaybio merged commit 9bb63c2 into cytomining:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants