Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Installation Dependency Gaps #232

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Address Installation Dependency Gaps #232

merged 2 commits into from
Sep 14, 2022

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Sep 13, 2022

Description

When installing Pycytominer using pip from Github hashes there is a dependency gap with pyarrow due to mismatches between requirements.txt and setup.py. This currently causes new functionality to be otherwise unavailable until the dependency is resolved manually.

Changes in this PR update setup.py to reference requirements.txt when installing Pycytominer. I've also added capitalization for globals to help make these more visible from a style perspective.

Many thanks go to @axiomcura for help in highlighting this issue!

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and one requested change (run black please)

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #232 (07157ea) into master (f3206da) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files          53       53           
  Lines        2772     2772           
=======================================
  Hits         2653     2653           
  Misses        119      119           
Flag Coverage Δ
unittests 95.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gwaybio
Copy link
Member

gwaybio commented Sep 14, 2022

I will merge once @falquaddoomi gives his 👍 - thanks @d33bs !

@gwaybio gwaybio merged commit 289c4d3 into cytomining:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants