Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flexible pyarrow dependency #236

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Enable flexible pyarrow dependency #236

merged 1 commit into from
Oct 28, 2022

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Oct 28, 2022

Description

This change updates the version requirement for pyarrow to be unconstrained by new releases. Pyarrow's current version is v9.0.0 whereas the version specification within requirements.txt for pyctyominer is statically set to v8.0.0. There are no functional issues within pycytominer as-is, but this may potentially cause issues with cross-dependent libraries for developers as pyarrow versions continue to be released.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need Faisal for this one

@gwaybio gwaybio merged commit e21cc10 into cytomining:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants