Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid re-validation for excluded features #243

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

johnarevalo
Copy link
Member

If an operation excluded a column, such column should not be validated by further operations. This will reduce the computation time. It will benefit list of operations sorted by computational cost (ascending).

What is the nature of your change?

  • Enhancement (speed).
  • This change requires a documentation update. Maybe explain the benefits of sorting operations by computational cost.

Checklist

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have deleted all non-relevant text in this pull request template.

@johnarevalo johnarevalo marked this pull request as draft November 25, 2022 21:17
@johnarevalo johnarevalo marked this pull request as ready for review November 28, 2022 23:22
@gwaybio
Copy link
Member

gwaybio commented Dec 15, 2022

@johnarevalo - is this ready for me to take a look? If so, please tag me

@johnarevalo
Copy link
Member Author

Thanks for your reply @gwaybio, yes this is ready for your input.

@gwaybio gwaybio self-requested a review December 16, 2022 18:34
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am excited about this change!

One comment worth discussion in the test but then I think this is straightforward to merge

pycytominer/tests/test_feature_select.py Show resolved Hide resolved
@gwaybio gwaybio self-requested a review December 19, 2022 20:55
@gwaybio gwaybio merged commit b789165 into cytomining:master Dec 19, 2022
@johnarevalo johnarevalo deleted the feat_exclude branch January 13, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants