-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add float_datatype parameter for SingleCells compartment load and merge performance flexibility #248
Conversation
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 95.74% 95.71% -0.03%
==========================================
Files 53 53
Lines 2822 2826 +4
==========================================
+ Hits 2702 2705 +3
- Misses 120 121 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @d33bs ! This should help @axiomcura in WayScience/cell-health-data#10 (I think this was the right PR to tag here, but it will also likely help many others as well!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @d33bs ! Only two minor comments but then I think we're good to merge.
Looks good! I'm going to merge. Thanks @d33bs |
Description
This change adds a float_datatype parameter for use with SingleCells compartment load and merge operations to assist with performance considerations (as cited within WayScience/cell-health-data#10 and other areas). In testing this locally using
np.float32
instead ofnp.float64
I found ~45% reduction in peak memory consumption while runningmerge_single_cells
on small testing datasets (this reduction may vary contingent on dataset).This change is also related to #198 and #227 (if only to notate datatype considerations).
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.