Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AWS obey excludes #256

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Make AWS obey excludes #256

merged 2 commits into from
Feb 17, 2023

Conversation

bethac07
Copy link
Member

@bethac07 bethac07 commented Feb 17, 2023

Description

The syntax used for the AWS sync command in collate.py works if used outside subprocess, but in the context of of subprocess, quotes should not be used. H/T to @bdiazroh for letting me know something was up.

What is the nature of your change?

  • Bug fix (fixes an issue).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

Codecov Report

Merging #256 (008a72f) into master (7e57132) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          53       53           
  Lines        2826     2826           
=======================================
  Hits         2705     2705           
  Misses        121      121           
Flag Coverage Δ
unittests 95.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pycytominer/cyto_utils/collate.py 54.73% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bethac07 bethac07 marked this pull request as ready for review February 17, 2023 02:38
pycytominer/cyto_utils/collate.py Outdated Show resolved Hide resolved
Co-authored-by: Gregory Way <gregory.way@gmail.com>
@bethac07
Copy link
Member Author

File had indeed already been blacked - single quotes was due to the previous double-quotes inside. Running black again produces no changes.

image

@bethac07 bethac07 merged commit b2c6cc4 into master Feb 17, 2023
@bethac07 bethac07 deleted the aws_obey_excludes branch February 17, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants