Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #290

Merged
merged 16 commits into from
Jun 13, 2023
Merged

Update docs #290

merged 16 commits into from
Jun 13, 2023

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Jun 10, 2023

Description

Updating to furo sphinx theme, adding README parsing, and some documentation cleanup in preparation for version 1 release.

will cause merge conflict with #289 (both update README)

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Merging #290 (6062cae) into master (921dcfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          57       57           
  Lines        3057     3057           
=======================================
  Hits         2908     2908           
  Misses        149      149           
Flag Coverage Δ
unittests 95.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gwaybio gwaybio requested a review from d33bs June 11, 2023 12:18
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The furo theme looks great - really neat to see the updates here and I'm excited for these changes. Please let me know if you have any questions or concerns about the comments in the review.

Alongside the comments, I also had the following thoughts:

  • Would make sense to outline the documentation build and deployment process and expectations somewhere (maybe in contributing.md docs?).
  • When I ran sphinx-build ... -W I noticed there was a warning which might be a quick fix that could be added alongside these changes: docstring of pycytominer.normalize.normalize:64:Unexpected indentation..

README.md Outdated Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
docs/requirements.txt Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/requirements.txt Show resolved Hide resolved
@gwaybio
Copy link
Member Author

gwaybio commented Jun 11, 2023

Thanks @d33bs !

Would make sense to outline the documentation build and deployment process and expectations somewhere (maybe in contributing.md docs?).

This is a great idea. I added a note in f94bbfb - please suggest changes if you can think to add anything else. Thanks!

When I ran sphinx-build ... -W I noticed there was a warning which might be a quick fix that could be added alongside these changes: docstring of pycytominer.normalize.normalize:64:Unexpected indentation..

Hmm, I am not seeing these warnings...

@gwaybio gwaybio requested a review from d33bs June 12, 2023 17:00
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for addressing the comments. I left a couple additional minor comments, please let me know if you have any questions.

.readthedocs.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@gwaybio gwaybio merged commit e4c4165 into cytomining:master Jun 13, 2023
@gwaybio gwaybio deleted the update-docs branch June 13, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants