-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #290
Update docs #290
Conversation
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 57 57
Lines 3057 3057
=======================================
Hits 2908 2908
Misses 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The furo
theme looks great - really neat to see the updates here and I'm excited for these changes. Please let me know if you have any questions or concerns about the comments in the review.
Alongside the comments, I also had the following thoughts:
- Would make sense to outline the documentation build and deployment process and expectations somewhere (maybe in
contributing.md
docs?). - When I ran
sphinx-build ... -W
I noticed there was a warning which might be a quick fix that could be added alongside these changes:docstring of pycytominer.normalize.normalize:64:Unexpected indentation.
.
Thanks @d33bs !
This is a great idea. I added a note in f94bbfb - please suggest changes if you can think to add anything else. Thanks!
Hmm, I am not seeing these warnings... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for addressing the comments. I left a couple additional minor comments, please let me know if you have any questions.
Co-authored-by: Dave Bunten <ekgto445@gmail.com>
Description
Updating to furo sphinx theme, adding README parsing, and some documentation cleanup in preparation for version 1 release.
will cause merge conflict with #289 (both update README)
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.