Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove master branch references after migrating to main #324

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

kenibrewer
Copy link
Member

Fixes #318

Description

As part of the transition to more inclusive language this removes references to the master branches that were previously present in the codebase.

What is the nature of your change?

  • Bug fix (fixes an issue).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

Codecov Report

Merging #324 (fc6bbba) into main (74e6c63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          56       56           
  Lines        3134     3134           
=======================================
  Hits         2990     2990           
  Misses        144      144           
Flag Coverage Δ
unittests 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kenibrewer
Copy link
Member Author

@d33bs Could I request a review on this please? Thanks!

@d33bs d33bs self-requested a review September 30, 2023 20:01
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thank you @kenibrewer !

As an aside, I think it might be good to double check the config under https://readthedocs.org/projects/pycytominer/ to make sure it references main moving forward. @gwaybio , do you know if we're able to change what branch or reference URL is used for documentation there?

@gwaybio
Copy link
Member

gwaybio commented Oct 2, 2023

do you know if we're able to change what branch or reference URL is used for documentation there?

Done! Changed to main in RTD. Docs are passing!

@kenibrewer
Copy link
Member Author

This is ready to merge.

@gwaybio gwaybio merged commit e98bf3d into cytomining:main Oct 2, 2023
10 checks passed
@gwaybio
Copy link
Member

gwaybio commented Oct 2, 2023

Thanks @kenibrewer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove master branch references after migrating to main
4 participants