Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix optional poetry dependencies #338

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Oct 26, 2023

Description

Optional pip dependencies were configured incorrectly and were always being installed. The dependencies have been reconfigured as optional and included in the expected "extras" groups.

Fixes #335

What is the nature of your change?

  • Bug fix (fixes an issue).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have deleted all non-relevant text in this pull request template.

📚 Documentation preview 📚: https://pycytominer--338.org.readthedocs.build/en/338/

@kenibrewer kenibrewer marked this pull request as draft October 26, 2023 18:49
@kenibrewer kenibrewer force-pushed the fix/poetry-extras branch 3 times, most recently from 6ad242c to 385dce7 Compare October 26, 2023 19:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #338 (542307d) into main (871b633) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          56       56           
  Lines        3134     3134           
=======================================
  Hits         2990     2990           
  Misses        144      144           
Flag Coverage Δ
unittests 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kenibrewer kenibrewer marked this pull request as ready for review October 26, 2023 20:22
Copy link
Member Author

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed

@kenibrewer kenibrewer requested a review from d33bs October 26, 2023 20:23
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a couple of comments and overall felt this looked good. I seek your input on the codecov.yml file changes specifically to make sure this is ready before an approval from me. Please don't hesitate to let me know if you have any questions.

.github/workflows/codecov.yml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Optional pip dependencies were configured incorrectly and were always being installed. The dependencies have been reconfigured as optional and included in the expected "extras" groups.

Fixes cytomining#335
pyproject.toml Show resolved Hide resolved
@kenibrewer kenibrewer merged commit c4688bb into cytomining:main Oct 29, 2023
10 checks passed
@kenibrewer kenibrewer deleted the fix/poetry-extras branch October 29, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Optional dependencies are specified incorrectly
3 participants