-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add commitizen cli and commit standards #340
Conversation
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 56 56
Lines 3135 3135
=======================================
Hits 2991 2991
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! These were thoughtful additions and appreciate the additional context in the PR description. I left a few comments which I hope to get your feedback on before an approval. Mostly here I wonder / worry about what happens with squashes and those who might be new to the procedures (and also might be developing locally instead of in the devcontainer).
e3c00aa
to
1291817
Compare
1291817
to
4772c1c
Compare
Commitizen cli will aid in commit formatting and changelog generation Address cytomining#333
4772c1c
to
71da6bc
Compare
@d33bs I made the following changes since your last review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the replies and follow up comments - LGTM.
Description
Commitizen pre-installed cli will aid in the generation of commit messages can be used for automatic changelog generation.
Address #333
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.