Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): remove gitpod support and update docs #347

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Oct 28, 2023

Description

Rationale for deprecating gitpod dev environment support in attached issue.

  • Removes gitpod configuration
  • Updates docs
  • Fixes incorrect create a codespace link

Closes #346

What is the nature of your change?

  • Bug fix (fixes an issue).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have deleted all non-relevant text in this pull request template.

Rationale for deprecating gitpod dev environment support in attached issue

Closes cytomining#346
@kenibrewer kenibrewer requested a review from d33bs October 28, 2023 19:27
@kenibrewer kenibrewer self-assigned this Oct 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #347 (890b715) into main (871b633) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          56       56           
  Lines        3134     3134           
=======================================
  Hits         2990     2990           
  Misses        144      144           
Flag Coverage Δ
unittests 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, LGTM. Sorry to see the option go away but I understand the reasons why.

Aside: not overly worried, but I wonder about eventual pricing changes with GitHub on this front and what could happen when/if that takes place.

@kenibrewer kenibrewer merged commit fc15168 into cytomining:main Oct 29, 2023
10 checks passed
@kenibrewer kenibrewer deleted the fix/deprecate-gitpod branch October 29, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationRequest: Remove Gitpod Support
3 participants