Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell.sh to fall back to docker compose (no dash) #920

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

Cleancookie
Copy link
Contributor

@Cleancookie Cleancookie commented Sep 18, 2022

Fix bug where docker-compose command not found

Goal

On a fresh Ubuntu install after installing Docker (and compose) by following https://docs.docker.com/engine/install/ubuntu/ results in an error saying that the command docker-compose is not found when running ./shell.sh to attach to the php devilbox container.

Did do a quick search to see if anyone else raised this issue but I couldn't find anything, my apologies if this is a repeat

DESCRIPTION

Did some quick Googling to find the difference between docker-compose and docker compose. TLDR: docker-compose is an older python implementation and docker compose is a v2 implementation of the same thing written in Go.

I've updated shell.sh to check if docker-compose exists first and if not then use docker compose

@Cleancookie Cleancookie changed the title shell.sh now falls back to docker compose (no dash) shell.sh to fall back to docker compose (no dash) Sep 18, 2022
@cytopia cytopia self-assigned this Dec 11, 2022
@cytopia cytopia merged commit 04c0e27 into cytopia:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants