Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Using ${var} in strings is deprecated, use {$var} instead #925

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Fix: Using ${var} in strings is deprecated, use {$var} instead #925

merged 1 commit into from
Oct 21, 2022

Conversation

vikas5914
Copy link
Contributor

Goal

Fix #924

@cytopia
Copy link
Owner

cytopia commented Oct 18, 2022

Is this going to be backwards compatible with old PHP versions as well?

@vikas5914
Copy link
Contributor Author

@cytopia backward completable from PHP v4.3 : https://3v4l.org/MPeNY

@cytopia cytopia merged commit 3bffa62 into cytopia:master Oct 21, 2022
@cytopia
Copy link
Owner

cytopia commented Oct 21, 2022

Thanks @vikas5914 👍

@vikas5914 vikas5914 deleted the patch-1 branch October 21, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Devilbox not yet ready for PHP 8.2
2 participants
@vikas5914 @cytopia