-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rendering cytoscape into WindowProxy document. #3130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good feature to add to the library, and it would be great to have it in the next release.
There are a few small details that we should sort out, and then we should get this merged in.
Adding the function makes sense to me. At the same time I have disabled the demo I added, since that is mostly meant for ensuring the feature works, not sure it should be there with the other demos. |
@AdamChlupacek, I'm seeing errors on the debug page: First: npm run watch Then on
|
@maxkfranz thank you for letting me know. Should be fixed now, I also tried the debug page and click through it, did not encounter any other reference issues. |
@AdamChlupacek, great. From a cursory look at the debug page, it looks like the renderer is working now. It looks like some automated test has failed in the GH actions. Would you please investigate that before we merge this in? |
@maxkfranz Thank you for letting me know, forgot to remove imports which are no longer used since we are using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks, @AdamChlupacek.
Let's merge this in for a feature release this week.
Associated issues: #3129
window
into reference towindow
of the container into which is the cytoscape rendered. This is done via changing thewindow
reference intocontainer.ownerDocument.defaultView
.Checklist
Author:
unstable
. Bug-fix patches can go on eitherunstable
ormaster
.Reviewers:
master
branch and theunstable
branch. Normally, this just requires cherry-picking the corresponding merge commit frommaster
tounstable
-- or vice versa.