Fix re. cxt events (& context menu extension)

[maxkfranz]

Cross-references to related issues. If there is no existing issue that describes your bug or feature request, then create an issue before making your pull request.

Associated issues:

• 3.30.1 breaks cytoscape.js-context-menus (& cxttap generally) #3262
• "free" event doesn't fire if you right click during drag and drop #3005

Notes re. the content of the pull request. Give context to reviewers or serve as a general record of the changes made. Add a screenshot or video to demonstrate your new feature, if possible.

• Resetting the flag allows cxttap to fire again
• You can test on the debug page:
  • npm run watch
  • Go to debug page
  • Go to 'Element events' in the sidebar
  • bind() to node for cxttap -- or paste in the console cy.nodes().on('cxttap', () => console.log('cxttap'))
  • Try to reproduce the issue as mentioned by Hasan (3.30.1 breaks cytoscape.js-context-menus (& cxttap generally) #3262 (comment))

Checklist

Author:

• The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
• N/A Added new CDN - PageCDN #2464 Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
• The associated GitHub issues are included (above).
• Notes have been included (above).

Reviewers:

• All automated checks are passing (green check next to latest commit).
• At least one reviewer has signed off on the pull request.
• For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

[maxkfranz]

@KonradHoeffner, would you test this on your app? You'll have to build the lib and use that build in place of what npm normally provides.

[maxkfranz]

@hasanbalci, would you verify that this works with your extension?

[maxkfranz]

@chrtannus, would you verify that this doesn't cause a regression re. #3005, which you reviewed before? The debug page (npm run watch) is fine for testing this.

[hasanbalci]

@maxkfranz I verify that it now works with the context-menus extension.

[KonradHoeffner]

@KonradHoeffner, would you test this on your app? You'll have to build the lib and use that build in place of what npm normally provides.

• @maxkfranz: Thanks for the fix, it does work in my app!

To be clear, it is a vite app and I did the following:

1. clone this repo and switched to fix/cxt-events-re-exts
2. npm install
3. npm run build
4. go to my app folder, update cytoscape.js to 3.30.1 and confirm that the context menu is still broken there
5. replace node_modules/cytoscape/dist in my app with the dist folder of cytoscape as produced in step 3

• vite dev --force dev mode context menu is restored after forcing vite to rebundle the dependencies
• delete dist folder, vite build, vite preview context menu is restored in preview of the actual app build as well

[maxkfranz]

Great. Thanks for the feedback, @hasanbalci and @KonradHoeffner.

[chrtannus]

@maxkfranz, It does not cause a regression re. #3005 -- on the debug page, pressing or clicking the right button did not interrupt any of these actions: panning, dragging a node, drag-selecting nodes with the selection rectangle (holding shift).