Force labels data type to be uint32 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziw-liu
added
upstream
|
@ziw-liu , this partially works for me. Half the labels are allocated a cluster ID whereas half of them are zeros. Is this related to some issue with the tracking metadata itself? |
|
I tested the same with the new predictions @alishbaimran generated and it works better. On annotating on the UMAP, the cluster id allocation excludes cells with partial bounding boxes at the boundary of the frame. This makes sense since those cells are not included in the analysis. |
|
@Soorya19Pradeep @alishbaimran Can you provide a review? I'd like to deploy this fix soon. |
|
Works for me! |
Soorya19Pradeep
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to upstream issue (napari/napari#7327), the colormap of labels cannot be changed if their dtype is not uint32, which causes hideous error when assigning manual cluster IDs to uint16 labels in napari-clusters-plotter.
This PR is a workaround when the fix upstream is pending.