Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding phate to the labels #22

Merged
merged 3 commits into from
Nov 21, 2024
Merged

adding phate to the labels #22

merged 3 commits into from
Nov 21, 2024

Conversation

edyoshikun
Copy link
Contributor

Here we want to add PHATE1 and PHATE2 to the labels layer if existing in the predictions.zarr

@edyoshikun edyoshikun requested a review from ziw-liu November 21, 2024 07:47
@ziw-liu ziw-liu added the enhancement New feature or request label Nov 21, 2024
@ziw-liu
build dynamic list of dimensionality reductions
1630c5f 
only load UMAP or PHATE coordinates it available
@ziw-liu
Copy link
Collaborator

ziw-liu commented Nov 21, 2024

Now it should work with any subset of dimensionality reductions in ["UMAP1", "UMAP2", "PHATE1", "PHATE2"].

@ziw-liu
Copy link
Collaborator

ziw-liu commented Nov 21, 2024

image

ziw-liu
ziw-liu approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edyoshikun I'll leave final tweaks and merging to you.

@edyoshikun edyoshikun merged commit 80b82f8 into main Nov 21, 2024
10 checks passed
@edyoshikun edyoshikun deleted the add_phate branch November 21, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziw-liu ziw-liu ziw-liu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edyoshikun @ziw-liu