Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong DOM values for xe-* interfaces #178 #180

Merged

Conversation

Gaste8
Copy link
Contributor

@Gaste8 Gaste8 commented Apr 20, 2022

Fixes #178.

For interfaces with zero lanes there is the tag "rx-signal-avg-optical-power" instead of
"laser-rx-optical-power" in the xml/json response and vice-versa.

Added clause to fix this.
-- If no value is available then try the other one.

Additional Question:
some devices use [0.0000 mW / - Inf dBm]
and others use [0.0001 mW / -40.00 dBm] as a lower bound for diagnostics values.
Should we set a standard and change one of these?

…-optical-power> instead of <laser-rx-optical-power> in the xml/json response and vice-versa.

Added clause to fix this.
-- If no value is available then try the other one.
@fstolba
Copy link
Contributor

fstolba commented May 22, 2022

FWIW we have this patch running on our production cluster for 2+ weeks without any problems 👍 .

It will certainly make sense to standardize on a single value to signify No signal. As far as I can tell, the value that will be reported is dependent on the transceiver model in use (probably transceiver vendor too) and JunOS version. For example 10G-LR shows -40 while 10G-SR shows -Inf in the same box.

@czerwonk czerwonk merged commit 97376fe into czerwonk:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong DOM values for xe-* interfaces
3 participants