Wrong DOM values for xe-* interfaces #178 #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178.
For interfaces with zero lanes there is the tag "rx-signal-avg-optical-power" instead of
"laser-rx-optical-power" in the xml/json response and vice-versa.
Added clause to fix this.
-- If no value is available then try the other one.
Additional Question:
some devices use [0.0000 mW / - Inf dBm]
and others use [0.0001 mW / -40.00 dBm] as a lower bound for diagnostics values.
Should we set a standard and change one of these?