Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alarms on multi-RE systems #217

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

Nothing4You
Copy link
Contributor

@Nothing4You Nothing4You commented Jun 15, 2023

This implements handling of multi-RE alarm responses, fixing #216.
It also introduces a few test cases to ensure multi-RE systems are being handled properly in the future.

Apparently GitHub doesn't like "fixing", here you go: fixes #216

This has been tested against SRX 300 series firewalls in single node and chassis cluster modes.

This implements handling of multi-RE alarm responses, fixing czerwonk#216.
It also introduces a few test cases to ensure multi-RE systems are being
handled properly in the future.
Copy link
Owner

@czerwonk czerwonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czerwonk czerwonk merged commit 9776067 into czerwonk:main Jul 5, 2023
@czerwonk
Copy link
Owner

czerwonk commented Jul 5, 2023

Thanks for your contribution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alarms are broken on multi-RE systems
2 participants